[linuxtv-cvs] dvb-kernel

Michael Krufky via CVS mkrufky at linuxtv.org
Sat Oct 1 18:29:46 CEST 2005

CVSROOT:	/cvs/linuxtv
Module name:	dvb-kernel
Changes by:	mkrufky	20051001 18:29:46

Modified files:
	linux/drivers/media/common: saa7146_i2c.c 
	linux/drivers/media/dvb/b2c2: flexcop-i2c.c 
	linux/drivers/media/dvb/dvb-usb: cxusb.c dibusb-common.c 
	                                 digitv.c dvb-usb-i2c.c 
	linux/drivers/media/dvb/pluto2: pluto2.c 
	linux/drivers/media/dvb/ttusb-budget: dvb-ttusb-budget.c 

Log message:
[PATCH] I2C: Kill i2c_algorithm.name (1/7)

The name member of the i2c_algorithm is never used, although all
drivers conscientiously fill it. We can drop it completely, this
structure doesn't need to have a name.

[PATCH] I2C: Kill i2c_algorithm.id (4/7)

There are no more users of i2c_algorithm.id, so we can finally drop
this structure member.

[PATCH] I2C: Kill i2c_algorithm.id (6/7)

In theory, there should be no more users of I2C_ALGO_* at this point.
However, it happens that several drivers were using I2C_ALGO_* for
adapter ids, so we need to correct these before we can get rid of all
the I2C_ALGO_* definitions.

Note that this also fixes a bug in media/video/tvaudio.c:

/* don't attach on saa7146 based cards,
because dedicated drivers are used */
if ((adap->id & I2C_ALGO_SAA7146))
return 0;

This test was plain broken, as it would succeed for many more adapters
than just the saa7146: any those id would share at least one bit with
the saa7146 id. We are really lucky that the few other adapters we want
this driver to work with did not fulfill that condition.

Signed-off-by: Jean Delvare <khali at linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>
Signed-off-by: Michael Krufky <mkrufky at linuxtv.org>

More information about the linuxtv-cvs mailing list