[vdr] VPS Timer stop too early

Klaus Schmidinger Klaus.Schmidinger at cadsoft.de
Sat Jul 30 13:13:13 CEST 2005

Klaus Schmidinger wrote:
> Oliver Holler wrote:
>> Hi,
>> I'm a great fan of the VPS function.
>> It was one of the main reason to use VDR.
>> Unfortunatelly the VPS timers do not work for me, as expected.
>> In general they stop too early.
>> They should stop recording when Running Status=1 (not running).
>> Ist that right?
>> ...

Ok, I found it.
It only happens with repeating timers, that's why my explicit
tests (with one time recordings) didn't show this error.

It is caused by a change I made in VDR 1.3.37:

--- timers.c    2005/06/11 14:19:58     1.32
+++ timers.c    2005/06/18 12:49:55     1.33
@@ -363,6 +363,8 @@

    if (HasFlags(tfActive)) {
       if (HasFlags(tfVps) && !Directly && event && event->Vps() && schedule && schedule->PresentSeenWithin(30)) {
+        if (startTime != event->Vps())
+           return false;
          startTime = event->StartTime();
          stopTime = event->EndTime();
          return event->IsRunning(true);

Simply remove these two lines and it should work again.
I'll need to look for a different way to make sure a VPS timer
only records a programme with exactly that VPS time.


More information about the vdr mailing list