[linux-dvb] Re: Oops with your patch to driver/av7110/saa7146_core.[ch]of 2002/10/24 16:22:20

[Holger Waechtler <holger@convergence.de>]

Hi Robert,

I'd like to apply your patch, but don't you want to create a dynamic 
dependency rule (like in DVB/apps/szap/Makefile) which calls gcc -M to 
create and update dependencies? This is simpler and more bulletproof.

Holger


Robert Schiele wrote:
> On Tue, Oct 29, 2002 at 11:42:51AM +0100, Holger Waechtler wrote:
> 
>>Hi Robert,
>>
>>please run make clean ; make -- there are some dependencies not correct, 
>>somehow make does not recognizes the change the saa7146 header file.
> 
> 
> So, how about the following patch?
> 
> Robert
> 
> Index: driver/Makefile
> ===================================================================
> RCS file: /cvs/linuxtv/DVB/driver/Makefile,v
> retrieving revision 1.38
> diff -u -r1.38 Makefile
> --- driver/Makefile	10 Oct 2002 19:22:28 -0000	1.38
> +++ driver/Makefile	29 Oct 2002 19:48:41 -0000
> @@ -91,12 +91,25 @@
>  dvb-core.o: $(dvb-core-objs)
>  	$(LD) -r -o $@ $(dvb-core-objs)
>  
> -dvb_demux.o: dvb_demux.h dmxdev.h
> +dvb_demux.o: dvb_demux.c compat.h dvb_demux.h demux.h
>  
> -dmxdev.o: dmxdev.h dvb_demux.h
> +dmxdev.o: dmxdev.c dmxdev.h ../include/linux/dvb/dmx.h dvbdev.h demux.h
>  
> -dvb_filter.o: dvb_filter.c dvb_filter.h
> +dvb_filter.o: dvb_filter.c dvb_filter.h demux.h
>  
> +dvb_frontend.o: dvb_frontend.c compat.h dvb_frontend.h		\
> +	../include/linux/dvb/frontend.h dvb_i2c.h dvbdev.h
> +
> +dvb_i2c.o: dvb_i2c.c compat.h dvb_i2c.h dvbdev.h
> +
> +dvb_ksyms.o: dvb_ksyms.c dmxdev.h ../include/linux/dvb/dmx.h dvbdev.h	\
> +	demux.h dvb_filter.h dvb_frontend.h				\
> +	../include/linux/dvb/frontend.h dvb_i2c.h dvb_demux.h		\
> +	dvb_net.h
> +
> +dvb_net.o: dvb_net.c ../include/linux/dvb/net.h demux.h dvb_net.h dvbdev.h
> +
> +dvbdev.o: dvbdev.c compat.h dvbdev.h
>  
>  include $(TOPDIR)/Rules.make
>  
> Index: driver/av7110/Makefile
> ===================================================================
> RCS file: /cvs/linuxtv/DVB/driver/av7110/Makefile,v
> retrieving revision 1.2
> diff -u -r1.2 Makefile
> --- driver/av7110/Makefile	10 Oct 2002 19:22:29 -0000	1.2
> +++ driver/av7110/Makefile	29 Oct 2002 19:48:42 -0000
> @@ -85,8 +85,33 @@
>  av7110_firm.h: Root Dpram fdump
>  	./fdump > av7110_firm.h
>  
> -av7110.o: av7110_firm.h
> +av7110.o: av7110.c ../../include/linux/dvb/frontend.h ../dvb_i2c.h	\
> +	../dvbdev.h ../dvb_frontend.h av7110.h ../demux.h		\
> +	../../include/linux/dvb/video.h					\
> +	../../include/linux/dvb/audio.h ../../include/linux/dvb/dmx.h	\
> +	../../include/linux/dvb/ca.h ../../include/linux/dvb/osd.h	\
> +	../../include/linux/dvb/net.h ../dvb_demux.h ../dmxdev.h	\
> +	../dvb_filter.h ../dvb_net.h saa7146_core.h saa7146_v4l.h	\
> +	saa7146_defs.h
>  
> -saa7146_core.o: saa7146_core.c saa7146.c
> +saa7146_core.o: saa7146_core.c saa7146_defs.h saa7146_core.h ../dvbdev.h  \
> +	saa7146_v4l.h av7110.h ../demux.h ../../include/linux/dvb/video.h \
> +	../../include/linux/dvb/audio.h ../../include/linux/dvb/dmx.h	  \
> +	../../include/linux/dvb/ca.h ../../include/linux/dvb/osd.h	  \
> +	../../include/linux/dvb/net.h ../dvb_demux.h ../dmxdev.h	  \
> +	../dvb_filter.h ../dvb_net.h ../compat.h ../dvb_i2c.h		  \
> +	saa7146.c
>  
> +av7110_ir.o: av7110_ir.c av7110.h ../dvbdev.h ../demux.h		\
> +	../../include/linux/dvb/video.h ../../include/linux/dvb/audio.h	\
> +	../../include/linux/dvb/dmx.h ../../include/linux/dvb/ca.h	\
> +	../../include/linux/dvb/osd.h ../../include/linux/dvb/net.h	\
> +	../dvb_demux.h ../dmxdev.h ../dvb_filter.h ../dvb_net.h		\
> +	input_fake.h
>  
> +fdump.o: fdump.c
> +
> +saa7146.o: saa7146.c saa7146_defs.h
> +
> +saa7146_v4l.o: saa7146_v4l.c saa7146_defs.h saa7146_core.h ../dvbdev.h	\
> +	saa7146_v4l.h saa7146.c
> Index: driver/frontends/Makefile
> ===================================================================
> RCS file: /cvs/linuxtv/DVB/driver/frontends/Makefile,v
> retrieving revision 1.4
> diff -u -r1.4 Makefile
> --- driver/frontends/Makefile	24 Oct 2002 11:28:27 -0000	1.4
> +++ driver/frontends/Makefile	29 Oct 2002 19:48:42 -0000
> @@ -61,3 +61,26 @@
>  rmmod:
>  	$(foreach frontend, $(obj-m), rmmod $(frontend:.o=); )
>  
> +alps_bsru6.o: alps_bsru6.c ../compat.h ../dvb_frontend.h		\
> +	../../include/linux/dvb/frontend.h ../dvb_i2c.h ../dvbdev.h
> +
> +alps_bsrv2.o: alps_bsrv2.c ../compat.h ../dvb_frontend.h		\
> +	../../include/linux/dvb/frontend.h ../dvb_i2c.h ../dvbdev.h
> +
> +alps_tdlb7.o: alps_tdlb7.c ../compat.h ../dvb_frontend.h		\
> +	../../include/linux/dvb/frontend.h ../dvb_i2c.h ../dvbdev.h
> +
> +alps_tdmb7.o: alps_tdmb7.c ../compat.h ../dvb_frontend.h		\
> +	../../include/linux/dvb/frontend.h ../dvb_i2c.h ../dvbdev.h
> +
> +cx24110.o: cx24110.c ../compat.h ../dvb_frontend.h			\
> +	../../include/linux/dvb/frontend.h ../dvb_i2c.h ../dvbdev.h
> +
> +grundig_29504-401.o: grundig_29504-401.c ../compat.h ../dvb_frontend.h	\
> +	../../include/linux/dvb/frontend.h ../dvb_i2c.h ../dvbdev.h
> +
> +grundig_29504-491.o: grundig_29504-491.c ../compat.h ../dvb_frontend.h	\
> +	../../include/linux/dvb/frontend.h ../dvb_i2c.h ../dvbdev.h
> +
> +ves1820.o: ves1820.c ../compat.h ../dvb_frontend.h			\
> +	../../include/linux/dvb/frontend.h ../dvb_i2c.h ../dvbdev.h
> 



-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe linux-dvb" as subject.