[linux-dvb] Re: [PATCH] Coding style for skystar2.c (both DVB anddvb-kernel)

[Wolfgang Thiel <w-thiel@gmx.net>]

On Tue, Nov 25, 2003 at 08:41:02AM +0100, Holger Waechtler wrote:
> [kernel freeze]
> ...
> Can please somebody else with a skystar2 test this? I'd like to find out 
> what's broken there CVS before applying more changes.
>
I can confirm the kernel freeze. This only happens with gcc-3.2: with
gcc-2.95 everything is (also with the patches ss.c).
There was an e-mail on libmpeg2-devel today, that some versions of gcc-3x
don't seem to initialise static data correctly to 0 .

Apropos gcc-2.95: I'll add a small patch to make it happy with sp887x.c.

Wolfgang
diff -uri dvb-kernel-031125-orig/linux/drivers/media/dvb/frontends/sp887x.c dvb-kernel/linux/drivers/media/dvb/frontends/sp887x.c
--- dvb-kernel-031125-orig/linux/drivers/media/dvb/frontends/sp887x.c	2003-11-24 19:51:10.000000000 +0000
+++ dvb-kernel/linux/drivers/media/dvb/frontends/sp887x.c	2003-11-25 11:40:25.000000000 +0000
@@ -197,6 +197,7 @@
 	int fd;
 	int filesize;
 	int fw_size;
+	mm_segment_t fs;
 
 	dprintk("%s\n", __FUNCTION__);
 
@@ -205,7 +206,7 @@
 
 	sp887x_microcontroller_stop (fe);
 
-	mm_segment_t fs = get_fs();
+	fs = get_fs();
 
 	// Load the firmware
 	set_fs(get_ds());