[linux-dvb] Re: [PATCH] Coding style for skystar2.c (both DVB anddvb-kernel)

[Holger Waechtler <holger@convergence.de>]

Roberto Ragusa wrote:
> Hi,
>
> as Holger asked me, I prepared a patch to fix the coding style (that is,
> variable name capitalization) for both the skystar2.c files.
>
> The two patches are rather big, so they have been compressed in bz2 format.
> There is nothing substantial in there, so I don't expect problems.
>
> DVB patch testing:
> ---------------
> I tested it and it works for me.
>
> dvb-kernel patch testing:
> -------------------------
> I compiled on 2.4 following Holger's instructions, but the module oops the
> kernel during initialization. This happens both with the original and
> with my modified version, so my modifications are perfect :-)))
> Joking aside, I spent some time comparing the object code in the two cases
> (neutralizing __FUNCTION__ and some printf) and I'm fairly sure the object
> code is identical. So I think the patch is correct and the problem is
> somewhere else (CVS currently unstable? incompatibility with my (not vanilla)
> kernel?).
Can you please report the oops-log with symbols resolved using ksymoops?

Can please somebody else with a skystar2 test this? I'd like to find out 
what's broken there CVS before applying more changes.

The DVB/ tree won't get maintained for improvements, there we apply 
serious bugfixes only - the next major release will be based on the 
dvb-kernel/ tree.

Holger



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.