[linux-dvb] Re: [PATCH] Skystar2 pid filters reorganization

["Augusto Cardoso" <augusto@carhil.net>]

Hi!

Please see my comments below.


*********** REPLY SEPARATOR  ***********

On 11/27/2003 at 5:59 PM Wolfgang Thiel wrote:

>On Thu, Nov 27, 2003 at 03:56:53PM +0100, Niklas Peinecke wrote:
>> ...
>> The six hw-filters we're talking about are all "in a line" on the board, 
>> so it should be possible to set them with some very small calculations 
>> in a single routine.
>>
>That's easily done: I did it yesterday, but read below.
>
>> ...
>
>
>I've not tried your patch yet, but I see one problem at a first glance:
>perhaps, close_whole_bandwidth() shouldn't be done as it is done now?
>It might have been opened, because the software filters need it, then
>comes a program opening and closing pid 0x2000: the software filters
>will stop to work then, if I'm not mistaken. Perhaps, we need a counter
>how often 0x2000 was requested, and only remove it when the counter is 1.
>

This should be called from the RemovePID. I made a change to get the 0x2000 working a while back and I added this to the remove function. The PATCH that was done last week doesn't have any code in the remove. I can post my patch, but it's a very simple change.

>
>I'm still struggling at another point:
>Only three of the old 6 hw filters at 0x300-0x30b are working:
>those where the high word is set; setting the low word doesn't seem
>to work: if you set an address to 0x00001fff, then a read will return
>0x00000000 :-(( Any idea, anyone?
>

Something is wrong with the software. That's not how the chip should work.

>Another question: can somebody explain to me why driver_initialize() is
>doing:
>        pid_set_group_pid(adapter, 0);
>        pid_set_group_mask(adapter, 0x1FE0);
>This starts a filter for pids 00-1f, and can never be stopped? (Well,
>it can be replaced in open_whole_bandwidth() ?).
>Why is it doing this? These are the SI pids, but not every software is
>actually needing them.
>

Keep in mind that the current skystar2.c driver was reverse engineered from the B2C2 driver.
The B2C2's original driver sets those registers because B2C2 's software always monitor the pids 00->1f. It's a long story why, but basic it has to do with transponder hopping and some other applications in Japan.
It's not necessary for skystar2.o.

	Augusto



-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.