Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: [PATCH] Coding style for skystar2.c (both DVBand dvb-kernel)



Michael Hunold wrote:
Hello Holger,

You can't use modprobe in the insmod.sh script, this would require to install the driver in the system before.

Ah, ok. As a hardcore "dvb-kernel" users I tend to forget that. 8-)

So perhaps a small howto that tells the user which cards might have which frontends would be best. Most newer cards (for example the Twinhan) only have one supported frontend, so this would be easy.


The twinhan driver is not really a generic frontend driver in the sense that the code is reusable by other cards, the ioctl code could also get implemented and registered directly in the twinhan bridge driver, this would make i2c probing for this card obsolete at all - the i2c bus would not even needed to get exported/registered to the DVB or kernel i2c subsystem. The same for the DEC2000-T driver.

Hmm, isn't this the case already for the twinhan driver?

There is a generic dvb-bt8xx.o, the generic bt878.o and the on-in-all "frontend" driver "dst.o" specific for the twinhan cards.
the dst_frontend driver (and the dec2000_frontend driver too) are pseudo-i2c device drivers. This makes no sense for these cards since the driver is working only in conjunction with the dst.o and ttusb_dec.o driver. As the implement the general attach/detach and register_i2c_device callbacks they get probed for every card - this does not makes much sense, right?

Instead it would be simpler and easier when the dvb_register_frontend() function would get called directly inside dst.o and ttusb_dec.o and no i2c bus would get registered via dvb_register_i2c_bus(). The struct dvb_i2c_bus pointer for dvb_register_frontend() can easily get faked.

Holger



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.



Home | Main Index | Thread Index