Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Small STV299 cleanup



Hi,

patch attached, added myself to authors. Would you accept Lindent patch? or 
Should that wait for an interim release not involving other major 
restructings (like sysfs, hopefully, if someone could help christian on the 
lkml).

Kenneth
Index: stv0299.c
===================================================================
RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/frontends/stv0299.c,v
retrieving revision 1.43
diff -u -r1.43 stv0299.c
--- stv0299.c	3 May 2004 16:29:28 -0000	1.43
+++ stv0299.c	5 Jun 2004 01:18:53 -0000
@@ -65,7 +65,6 @@
 #endif
 
 static int stv0299_status = 0;
-static int disable_typhoon = 0;
 
 #define STATUS_BER 0
 #define STATUS_UCBLOCKS 1
@@ -1277,6 +1276,8 @@
 
 	printk ("%s: try to attach to %s\n", __FUNCTION__, adapter->name);
 
+    // FIXME: Can't we bring some sort of ID in here?
+    //          adapter->id?
 	if ( strcmp(adapter->name, "Technisat SkyStar2 driver") == 0 )
 	{
 	    printk ("%s: setup for tuner Samsung TBMU24112IMB\n", __FILE__);
@@ -1299,8 +1300,7 @@
 	}
 
 	if ((ret = i2c_transfer(i2c, msg2, 2)) == 2) {
-		if ( strcmp(adapter->name, "KNC1 DVB-S") == 0 &&
-		     !disable_typhoon )
+		if ( strcmp(adapter->name, "KNC1 DVB-S") == 0 )
 		{
 			// Typhoon cards have unusual wiring.
 			printk ("%s: setup for tuner SU1278 (TSA5059 synth) on"
@@ -1446,11 +1446,10 @@
 module_exit (exit_uni0299);
 
 MODULE_DESCRIPTION("Universal STV0299/TSA5059/SL1935 DVB Frontend driver");
-MODULE_AUTHOR("Ralph Metzler, Holger Waechtler, Peter Schildmann, Felix Domke, Andreas Oberritter, Andrew de Quincey");
+MODULE_AUTHOR("Ralph Metzler, Holger Waechtler, Peter Schildmann, Felix Domke, "
+              "Andreas Oberritter, Andrew de Quincey, Kenneth Aafløy");
 MODULE_LICENSE("GPL");
 
 MODULE_PARM(stv0299_status, "i");
 MODULE_PARM_DESC(stv0299_status, "Which status value to support (0: BER, 1: UCBLOCKS)");
 
-MODULE_PARM(disable_typhoon, "i");
-MODULE_PARM_DESC(disable_typhoon, "Disable support for Philips SU1278 on Typhoon hardware.");

Home | Main Index | Thread Index