[linux-dvb] Re: av7110.h audcom() bug ?

[Johannes Stezenbach <js@convergence.de>]

Jeremy Jones wrote:
> I was browsing through some of the dvb code and may have spotted a
> small bug in the audcom() function.  The function calls the
> av71110_fw_cmd() function with a num argument of 4 yet only two
> arguments are actually passed in:
> 
>         return av7110_fw_cmd(av7110, COMTYPE_MISC, AV7110_FW_AUDIO_COMMAND, 4,
>                              (com>>16), (com&0xffff));
> 
> Shouldn't this only be passing in a 2 for the num argument or am I
> misunderstanding something here ?

Yes seems to be a copy&paste bug (from vidcom). Anyway, IMHO it's harmless
(two words of trailing garbage sent, I doubt the varargs stuff reading
from the stack would trigger anything in this case).

Fixed in CVS.

Thanks for reporting,
Johannes