[linux-dvb] Re: AirStar2 probs with the CVS drivers

[Johannes Stezenbach <js@convergence.de>]

Janne Liimatainen wrote:
> 
> DVB: registering new adapter (Technisat SkyStar2 driver).
> flexcop_i2c_func
> mt352_read_register: readreg error (ret == -38)
> dvbfe_mt352: Setup for TDTC9251DH01C.
> DVB: registering frontend 0 (DVB-T Zarlink MT352 demodulator driver)...

The readreg error is generated by mt352_detect_avermedia_771() and
is harmless.

BTW, looking at master_xfer() in skystar2.c, I wonder if the
driver currently works for the Avermedia 771. Because it
looks to me like I2C_M_NOSTART flag is unhandled. Patch
below might fix this, it would be nice if someone could test it.


Index: skystar2.c
===================================================================
RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/b2c2/skystar2.c,v
retrieving revision 1.33
diff -u -p -r1.33 skystar2.c
--- skystar2.c	30 Jul 2004 00:28:26 -0000	1.33
+++ skystar2.c	30 Jul 2004 14:15:44 -0000
@@ -309,7 +309,7 @@ static int master_xfer(struct dvb_i2c_bu
 	}
 
 	// read command
-	if ((num == 2) && (msgs[0].flags == 0) && (msgs[1].flags == I2C_M_RD) && (msgs[0].buf != NULL) && (msgs[1].buf != NULL)) {
+	if ((num == 2) && !(msgs[0].flags & I2C_M_RD) && (msgs[1].flags & I2C_M_RD) && (msgs[0].buf != NULL) && (msgs[1].buf != NULL)) {
 
 		ret = flex_i2c_read(tmp, 0x10000000, msgs[0].addr, msgs[0].buf[0], msgs[1].buf, msgs[1].len);
 

Johannes