[linux-dvb] ttusb_dec.c and usb_unlink_urb

[Nyk Tarr <nyk@giantx.co.uk>]

Hi,


I'm getting badness using 2.6.9-rc2-mm1...

Sep 17 20:19:26 natsu kernel: usb_unlink_urb() is deprecated for synchronous unlinks.  Use usb_kill_urb() instead.

And some more stuff. Looks like the culprits are some or all of:

linux/drivers/media/dvb/ttusb-budget/dvb-ttusb-budget.c:844:		usb_unlink_urb(ttusb->iso_urb[i]);
linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c:793:			usb_unlink_urb(dec->iso_urb[i]);
linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c:858:					usb_unlink_urb(dec->iso_urb[i - 1]);
linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c:1418:		usb_unlink_urb(dec->iso_urb[i]);
linux/drivers/media/dvb/dibusb/dvb-dibusb.c:293:		usb_unlink_urb(dib->buf_urb);
patches-2.6/11-DVB-new-driver-dibusb.diff:301:+		usb_unlink_urb(dib->buf_urb);

The relevent comment is in src/linux/drivers/usb/core/urb.c:

* In the past, clearing the URB_ASYNC_UNLINK transfer flag for the
* URB indicated that the request was synchronous.  This usage is now
* deprecated; if the flag is clear the call will be forwarded to
* usb_kill_urb() and the return value will be 0.  In the future, drivers
* should call usb_kill_urb() directly for synchronous unlinking.

HTH

ta
Nyk
-- 
/__
\_|\/
   /\