[linux-dvb] Re: refactoring

[Andrew de Quincey <adq_dvb@lidskialf.net>]

On Thursday 07 Oct 2004 17:34, Michael Hunold wrote:
> Hi,
>
> On 06.10.2004 21:18, Andrew de Quincey wrote:
> > If you keep going on this line of thought, you end up with:
> >
> > -----------
> > struct dvb_frontend_api {
>
> [...]
>
> >         int (*fe_read_ber)(void* data, __u32 ber);
> >         int (*fe_read_signal_strength)(void* data, __u16 strength);
> >         int (*fe_read_snr)(void* data, __u16 snr);
> >         int (*fe_read_ucblocks)(void* data, __u32 ucblocks);
>
> Shouldn't we simply create a
>
> struct dvb_fe_status {
>  __u16 flags;
>  __u32 ber;
>  __u16 strength;
>  __u16 snr;
>  __u32 ucblocks;
>  __u32 reserved[4];
> };
>
> #define DVB_FE_BER_VALID 0x1
> #define DVB_FE_STRENGTH_VALID 0x2
> #define DVB_FE_SNR_VALID 0x4
> #define DVB_FE_UCBLOCKS_VALID 0x8
>
> and only provide one function to query these informations?
>
> For V3 this doesn't matter because the ioctl will only deliver one value
> at a time. But V4 already has a similar kind of simplification and I'd
> like to keep the frontend stuff in sync.
>
> Perhaps we can introduce a new ioctl that provides all informations to
> userspace at once.

Yeah that would be nicer.

I was also thinking of a general "settings" IOCTL to initially setup the 
frontend... e.g. for FE_ENABLE_HIGH_LNB_VOLTAGE.