Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: refactoring



Gerd Knorr wrote:
> struct dvb_fe* create_<fename>(/* whatever is needed for the fe in question */);

I would prefere this to the current code.

However, looking at av7110.c:frontend_init() I think that create_<fename>()
would get too much paramters, which would make the code unreadable.

We could define a struct <fename>_config and pass that to
create_<fename> to get around this. <fename>_config could then
be part of the frontends private data struct, and be assigned
in create_<fename> via struct copy.

Johannes




Home | Main Index | Thread Index