[linux-dvb] Re: refactoring

[Andrew de Quincey <adq_dvb@lidskialf.net>]

> > I have to say that I prefer Andrew's approach much more, it's simply
> > more professional + easier to understand and maintain.
>
> No, it is a bad designed interface.  I'll drop the "more professional"
> into the waste basket, thats just a buzzword, and I don't want to play
> buzzword bingo here.
>
> Andrew's approach might be easier to understand on a first sight.  Look
> again, it's not.  You have one struct with both config info and state
> info mixed in there.  It's not clear who has to setup stuff:  It is the
> dvb adapter driver or is it the frontend driver?  Same for releasing the
> stuff.

Well actually, that is why I marked all the private stuff with the comment 
"frontend private data" in the structure definititions. Which is much clearer 
than most of the kernel where you are usually told to "RTFS" to find out such 
things. :)

Anyway, I will not argue any more about this until I've had a chance to 
investigate your proposal.