[linux-dvb] Re: refactoring

[Andrew de Quincey <adq_dvb@lidskialf.net>]

On Monday 11 Oct 2004 11:06, Gerd Knorr wrote:
> > extern int dvb_register_frontend(struct dvb_adapter* dvb,
> >                                  struct dvb_frontend_ops* ops,
> >                                  void* adapter_data,
> >                                  void* demodulator_config,
>
>                                    ^^^^^^^^^^^^^^^^^^^^^^^^
>
> >                                  struct module* module,
> >                                  struct dvb_frontend** fe);
>
> And that is exactly the point where the config stuff isn't type safe
> any more.  Without being typesave it's easy to avoid the direct symbol
> dependency, we already had that ;)

Hmm, yeah.

> I think it isn't wise to create a all-in-one function for that as you
> loose flexibility.  And I've already found one bug: It doesn't care
> about the PLL issue.  To fix that you need even more arguments, that
> isn't going to be pretty ...

Yeah  - this is exactly why I left the i2c_adapter in the config structs - 
otherwise you end up with six arguments to the XXX_attach() functions.

I don't really see the problem with having it in there - it is an external 
piece of information supplied to the demodulator by the adapter - which 
pretty much fits with the sort of thing that should be in config to me.