[linux-dvb] V4 API change: ioctl int arguments

[Johannes Stezenbach <js@linuxtv.org>]

Hi,

about three months back we were told that the trick we use to simplify
some ioctls with integer arguments is BAD. E.g.:

  #define DVB_DEMUX_SET_TS_DECODER_FEED _IO(DVB_IOCTL_BASE, 0x23 /* uint16_t pid */)

must be defined as

  #define DVB_DEMUX_SET_TS_DECODER_FEED _IOW(DVB_IOCTL_BASE, 0x23, uint16_t /* pid */)

http://www.google.com/groups?hl=en&lr=&selm=2nqk6-6GQ-11%40gated-at.bofh.it


That means that code which did

  ioctl(dmxfd, DVB_DEMUX_SET_TS_DECODER_FEED, 0x123);

must be change to read

  uint16_t pid = 0x123;
  ioctl(dmxfd, DVB_DEMUX_SET_TS_DECODER_FEED, &pid);


We cannot change this without breaking binary compatibility, so
we won't touch the V3 API, but we will do as we were told for V4.


Johannes