[linux-dvb] Re: [PATCH] dvb-ttpci+budgetpatch no rps on init

[emard@softhome.net]

HI Johannes

during initialization of saa7146 I'd suggest
to also stop rps with dma, but that's not enough.

I think better initialization procedure would be
as follows (not included in this patch)

1. stop all rps
2. prevent all irq's
3. stop all dma's

Emard
diff -pur dvb-kernel.orig/linux/drivers/media/common/saa7146_core.c dvb-kernel/linux/drivers/media/common/saa7146_core.c
--- dvb-kernel.orig/linux/drivers/media/common/saa7146_core.c	2005-01-09 11:39:17.000000000 +0100
+++ dvb-kernel/linux/drivers/media/common/saa7146_core.c	2005-01-09 11:47:35.000000000 +0100
@@ -380,8 +380,8 @@ static int saa7146_init_one(struct pci_d
 	/* disable all irqs */
 	saa7146_write(dev, IER, 0);
 
-	/* shut down all dma transfers */
-	saa7146_write(dev, MC1, 0x00ff0000);
+	/* shut down all dma transfers and rps tasks */
+	saa7146_write(dev, MC1, 0x30ff0000);
 
 	/* clear out any rps-signals pending */
 	saa7146_write(dev, MC2, 0xf8000000);
Only in dvb-kernel/linux/drivers/media/common: saa7146_core.c~