[linux-dvb] Re: Nova-T - tda1004x: waiting for firmware upload...

[Alberto López Navarro <alopez@ambar.es>]

	Couldn't it be that there is a mismatch in parameters between the 
declaration of request_firmware in firmware.h and the actual call in tda1004x.c?

	IMO, the problem is not in tuning as has been somewhere else suggested, but
in getting to the firmware file.

tda1004x.h: ***********************************

struct tda1004x_config
{
	(...)

	/* request firmware for device */
	int (*request_firmware)(struct dvb_frontend* fe, const struct firmware **fw, char* name);
};

include/linux/firmware.h: *********************

int request_firmware(const struct firmware **fw, const char *name,
                     struct device *device);

tda1004x.c: ***********************************

	/* request the firmware, this will block until someone uploads it */
	printk("tda1004x: waiting for firmware upload (%s)...\n",TDA10045_DEFAULT_FIRMWARE);
	ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
	if (ret) {
		printk("tda1004x: no firmware upload (timeout or file not found?)\n");
	   	return ret;
	}


	Unless the pointer to function in struct tda1004x_config refers to another
declaration of request_firmware, but I haven't been able to find any.

-----Mensaje original-----
De: Johannes Stezenbach [mailto:js@linuxtv.org]
Enviado el: Thursday, February 03, 2005 3:36 PM
Para: linux-dvb@linuxtv.org
Asunto: [linux-dvb] Re: Nova-T - tda1004x: waiting for firmware
upload...


On Wed, Feb 02, 2005 at 08:49:44AM +1100, Hamish Moffatt wrote:
> On Tue, Feb 01, 2005 at 07:08:39PM +0000, Dan Robinson wrote:
> > tda1004x: waiting for firmware upload...
> 
> It doesn't mean it failed. (I think you do get a follow-up message if it
> fails.)

I corrected this in CVS. You will get a message when firmware has
been loaded OK.

Johannes