[vdr] Re: AIO 14.08 - a bug in osd.c/cOsdMenu::hk?

[Carsten Koch <Carsten.Koch@icem.de>]

AIO 14.08 patches osd.c/cOsdMenu::hk so the hot keys restart with 0
after the 9th line:
1 first
2 second
...
9 nineth
0 tenth
1 eleventh
Is that a bug or does it make sense?

Is 1, 2, 3, 4, 5, 6, 7, 8, 9, 0 for the first 10 lines 
and no hot key after the 10th line not what we want?

Here is cOsdMenu::hk from vdr 1.0.4


const char *cOsdMenu::hk(const char *s)
{
  static char buffer[32];
  if (s && hasHotkeys) {
     if (digit == 0 && '1' <= *s && *s <= '9' && *(s + 1) == ' ')
        digit = 10; // prevents automatic hotkeys - input already has them
     if (digit < 9) {
        snprintf(buffer, sizeof(buffer), " %d %s", ++digit, s);
     if (digit == 9) {
      digit = -1;
  }
        s = buffer;
        }
     }
  return s;
}


and here is a suggested fix:


const char *cOsdMenu::hk(const char *s)
{
  static char buffer[32];
  if (s && hasHotkeys) {
     if (digit == 0 && '1' <= *s && *s <= '9' && *(s + 1) == ' ')
        digit = 11; // prevents automatic hotkeys - input already has them
     if (digit < 10) {
        ++digit;
        snprintf(buffer, sizeof(buffer), " %c %s", digit % 10 + '0', s);
        s = buffer;
        }
     }
  return s;
}


Carsten.


Andy Grobb wrote:
> 
> New AIO for VDR 1.0.4
> 
> Video Disk Recorder AIO-Patch Revision History
> ----------------------------------------------
> 
> 2002-08-14:
> 
> - DVD Hotfixes (Thanks to Andreas Schultz)
> - Added Symbols for Teletxt, Multican, Dolby and Cryptcan (E/D in
> Setup(OSD))
> 
> 2002-08-08:
> 
> - Added Calender Patch
> - Updated MP3 Patch to version 0.6.2
> 
> http://www.linvdr.org/download/VDR-AIO/vdr-1.0.4-AIO-14.08.diff.gz
> 
> Andy

-- 
   __________________________________________________________
  (                                                          )
  | Carsten Koch                  Phone: +49-4286-920001     |
  | ICEM Technologies GmbH          Fax: +49-4286-1608       |
  | Sotheler Mühlenweg 15        mailto:Carsten.Koch@icem.de |
  | 27404 Elsdorf-Hatzte, Germany  http://www.icem.com       |
  (__________________________________________________________)