[vdr] Re: Makefile bug in vdr 1.1.20

[Robert Schiele <robert.schiele@t-online.de>]

On Thu, Jan 02, 2003 at 08:32:24PM +0100, Clemens Kirchgatterer wrote:
> Clemens Kirchgatterer <clemens@thf.ath.cx> wrote:
> 
> > 
> > in vdr-1.1.20/libdtv/libvdr/Makefile 
> > 
> > CFLAGS ?= -O2 -g -Wmissing-prototypes -Wstrict-prototypes \
> >          -Wimplicit -D__USE_FIXED_PROTOTYPES__ -I../include # -DDEBUG
> > 
> > when CFLAGS are defined in the outside environment the important
> > -I../include parameter will not get set. -I should get defined
> > independently.
> 
> the Makefile should get changed to something like that:
> 
> CFLAGS ?= -O2 -g -Wmissing-prototypes -Wstrict-prototypes \
>          -Wimplicit -D__USE_FIXED_PROTOTYPES__
> 
> INCLUDE = -I../include
> 
> [..]
> 
> 
> .c.o:
>    $(COMPILE.c)   $(INCLUDE) $(DEFINES) $(CFLAGS) -c $< $(OUTPUT_OPTION)
> 
> .cpp.o:
>    $(COMPILE.cpp) $(INCLUDE) $(DEFINES) $(CFLAGS) -c $< $(OUTPUT_OPTION)

Why not something linke that:

CFLAGS ?= -O2 -g -Wmissing-prototypes -Wstrict-prototypes \
         -Wimplicit -D__USE_FIXED_PROTOTYPES__

CFLAGS += -I../include

If you did it that way, you do not need to redefine implicit rules.

Although, I am not that sure whether all this conditional CFLAGS stuff
was really a very good idea.  But that might be my personal paranoia.

Robert

-- 
Robert Schiele			Tel.: +49-621-181-2517
Dipl.-Wirtsch.informatiker	mailto:rschiele@uni-mannheim.de

-- Attached file included as plaintext by Listar --

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iQEVAwUBPhSvMcQAnns5HcHpAQGeswf+Kev1t+Y6/pwF/xI/Mw7sba4MjjuyUC1d
FoU4Jrfleb8J/XdRxFVtfTdypeFVuI/BCqMOflOeymIaMQU9cq26ClbDtHg9zR6a
X4yVRWdtxcU6U658ei6MndMxIihzloqQ3ZYamjthc6LQCNjgbUZZ5/95FCJ32OWW
YpWTxY89z1W+C/i9oH4veVoMrXIgW3fTR4ND5l2OsgLhL2/NOrv2hOuHTGW/A5Q5
XKkgotXMe9Cd97b4apwFc3ekafIqxnmqHX9ggd2K8EHjqt1dUakKDqNK/1YyN9l4
sR9Xh/DduFI148vVthvwR/oua1dg2i0dBi1Wy8xZ9MI7hFbP65Hxzw==
=N3KU
-----END PGP SIGNATURE-----



-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe vdr" as subject.