[vdr] Re: help on prefermenu plugin

[vdr@olivierjacques.com]

First, sorry if I break the thread, but my email account (hotmail) has been 
banned from listar :(

About your problem I just realized that I left the prefermenu.diff patch in the 
0.5.1 release. This is not needed. Please install a fresh prefermenu 0.5.1.
For the rest, it should work. 
With 0.5.1, please check that you have a keymacros.conf file with, for example:
Blue      Timers
Yellow    @prefermenu

Do you have any specific log message that appear in the log?

Also, another user (Manuel Hartl) reported that deleting a channel that is 
marked as preferred in VDR channels.conf was making the plugin crash. 
It will be in the next release, but, in the meantime, this is fixed with the 
following patch:
---------------------------- Cut here
diff -ruN ./prefermenu-0.5.1/HISTORY ./prefermenu-0.5.2/HISTORY
--- ./prefermenu-0.5.1/HISTORY	Thu Feb 20 23:58:40 2003
+++ ./prefermenu-0.5.2/HISTORY	Thu Apr  3 00:01:22 2003
@@ -1,6 +1,12 @@
 VDR Plugin 'prefermenu' Revision History
 ----------------------------------------
 
+2003-03-xx: Version 0.5.2 - Olivier Jacques
+- Fixed a crash when prefermenu is opened a one
+  of the prefered channels has been removed in 
+  VDR's channels.conf (thanks to Manuel Hartl for
+  reporting this one).
+
 2003-02-20: Version 0.5.1 - Olivier Jacques and DOm
 - Changed from channel number to unique channel IDs
   (thanks to DOm)
diff -ruN ./prefermenu-0.5.1/preferchannel.c ../prefermenu-0.5.2/preferchannel.c
--- ./prefermenu-0.5.1/preferchannel.c	Thu Feb 20 23:37:14 2003
+++ ./prefermenu-0.5.2/preferchannel.c	Wed Apr  2 23:55:51 2003
@@ -28,6 +28,14 @@
 
 bool cPreferedChannel::Save(FILE *f)
 {
+  /* Fix crash problem reported by Manuel Hartl    */
+  /* when loading a non existing prefered channel  */
+  cChannel *channel;
+  channel = Channels.GetByChannelID(GetIndex(), true);
+  if (channel == NULL) {
+    isyslog("Prefered channel '%s' does not exist anymore. Removing\n", 
Index.ToString());
+    return true;
+  }
   if (!(PreferedChannelsList.channel_to_remove == GetIndex()))
        return fprintf(f, "%s\n", Index.ToString()) > 0;
      else return true;
diff -ruN ./prefermenu-0.5.1/prefermenu.c ./prefermenu-0.5.2/prefermenu.c
--- ./prefermenu-0.5.1/prefermenu.c	Fri Feb 21 00:05:56 2003
+++ ./prefermenu-0.5.2/prefermenu.c	Wed Apr  2 23:21:37 2003
@@ -64,6 +64,8 @@
 {
   // Perform the action when selected from the main VDR menu.
   PreferedChannelsList.Load(AddDirectory(ConfigDirectory(),"prefermenu.conf"));
+  /* Saving after loading allows to clean the file */
+  PreferedChannelsList.Save();
   config.height=240;
   return new cPreferOsd;
 }
---------------------------- Cut here

------
Hi,
	I've a problem with "prefermenu plugin vers 0.5.1" in VDR rel 1.1.25
... I patch with prefermenu.diff and compile vdr and plugins, create file
prefermenu.conf  (echo 1 > prefermenu.conf) ... 

 ... it seems to work, but I can't seee it! I can add, switch to a preferred
channel (I controlled the file also).

I think that the problem is in values of parameters I select ... could
anyone mail his/her settings?

	thanx
		Guido


-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe vdr" as subject.