[vdr] Re: integration of keyboard patch in vdr

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Jan Rieger wrote:
> 
> > -----Original Message-----
> > From: vdr-bounce@linuxtv.org [mailto:vdr-bounce@linuxtv.org]
> > On Behalf Of steffen moldaner
> > Sent: Wednesday, May 21, 2003 1:28 PM
> > To: vdr@linuxtv.org
> > Subject: [vdr] Re: integration of keyboard patch in vdr
> >
> >
> > > Hmmm ... then your script starts vdr in a manner which force vdr to
> > > loose its own terminal process group, e.g. by appending `&'
> > to the vdr
> > > _or_ rc-script comand line.  In this case the controlling
> > tty is lost.
> >
> > I must start vdr in background with & or --daemon in
> > rc-script. With the patch, it's no problem to use the
> > keyboard. That's why I asked to integrate this patch. I
> > haven't noticed any other problems with the patch applied.
> 
> OK. At the moment vdr turns off the keyboard if the
> --daemon switch is used or vdr sees that it is not the
> owner of the terminal (different group id).
> 
> I think vdr shouldn't turn off the keyboard if someone
> uses explicitly the --terminal switch.
> (interpet --terminal as: force using keyboard)
> 
> > Am I the only one starting vdr per rc-script and using
> > keyboard with problems?
> 
> I've looked in the logs: there are so many downloads of
> the patch that you shurly aren't the only one who uses it.
> 
> @Klaus
> Could you please change this check in the suggested manner?

Actually I only wanted to fix bugs until version 1.2.0, and I wouldn't
actually call this a bug because a _daemon_ normally has no connection
to a keyboard - or can anybody give an example where this is the case?

Anyway, if you want this changed, please post a patch here on the list
so that others can test it - and that we know who's to blame if anything
is broken by doing this ;-)

Klaus
-- 
_______________________________________________________________

Klaus Schmidinger                       Phone: +49-8635-6989-10
CadSoft Computer GmbH                   Fax:   +49-8635-6989-40
Hofmark 2                               Email:   kls@cadsoft.de
D-84568 Pleiskirchen, Germany           URL:     www.cadsoft.de
_______________________________________________________________


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.