[vdr] Re: integration of keyboard patch in vdr

["Jan Rieger" <jan@ricomp.de>]

> -----Original Message-----
> From: vdr-bounce@linuxtv.org [mailto:vdr-bounce@linuxtv.org] 
> On Behalf Of Klaus Schmidinger
> Sent: Wednesday, May 21, 2003 2:09 PM
> To: vdr@linuxtv.org
> Subject: [vdr] Re: integration of keyboard patch in vdr
> 
> 
> Jan Rieger wrote:
> > 
> > > -----Original Message-----
> > > From: vdr-bounce@linuxtv.org [mailto:vdr-bounce@linuxtv.org] On 
> > > Behalf Of steffen moldaner
> > > Sent: Wednesday, May 21, 2003 1:28 PM
> > > To: vdr@linuxtv.org
> > > Subject: [vdr] Re: integration of keyboard patch in vdr
> > >
> > OK. At the moment vdr turns off the keyboard if the
> > --daemon switch is used or vdr sees that it is not the
> > owner of the terminal (different group id).
> > 
> > I think vdr shouldn't turn off the keyboard if someone
> > uses explicitly the --terminal switch.
> > (interpet --terminal as: force using keyboard)
> > 
> > @Klaus
> > Could you please change this check in the suggested manner?
> 
> Actually I only wanted to fix bugs until version 1.2.0, and I 
> wouldn't actually call this a bug because a _daemon_ normally 
> has no connection to a keyboard - or can anybody give an 
> example where this is the case?

What in your eyes is the different between fetching keystrokes
from a virtual terminal (vdr in deamon mode) or from a network
port (telnet server) or from an IR receiver over serial line
(lircd)?
All these deamons are reading input from an unix file (STDIN or
socket or hardware port). OK, a deamon per default hasn't
such a thing like STDIN. But: if --terminal is used, vdr closes
the (in this case not available) STDIN and opens any specified
file (eg. /dev/tty12) and connects it to stdin. So vdr can read
from that file by accessing a variable named stdin. Nothing
special.

Really, I can't see any difference. So why shouldn't vdr do it?

Anyway, if I tell a program to do something (vdr _has_ the
--terminal switch) and that program doesn't it althought it could
do it - i would call it a bug.


> Anyway, if you want this changed, please post a patch here on 
> the list so that others can test it - and that we know who's 
> to blame if anything is broken by doing this ;-)

For me vdr works great. I'm starting it the following way:

  runvdr < /dev/tty12 > /dev/tty12 2> /dev/tty12 &

This way I can start vdr in background plus I can see all the
output during loading the DVB drivers, can see the output from
vdr _and_ can input key strokes into vdr.

@Steffen
Perhaps that solves your problem without the keyboard patch, too.

Although the question comes up to my mind why we need such a thing
like --terminal.

Jan



-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.