[vdr] Re: VDR developer version 1.3.0

[Sergei Haller <Sergei.Haller@math.uni-giessen.de>]

On Mon, 5 Jan 2004, Klaus Schmidinger (KS) wrote:

KS> Well, a further look into the original 'libdtv' code showed that
KS> it had checked for
KS>
KS>          if ((*Buffer >= ' ' && *Buffer <= '~') || (*Buffer == '\n') ||
KS>              (*Buffer >= 0xa0))
KS>
KS> while the new 'libsi' code checks
KS>
KS>        if (    ((' ' <= *from) && (*from <= '~'))
KS>             || (*from == '\n')
KS>             || ((0xA0 <= *from) && (*from <= 0xFF))
KS>
KS> I believe the last line here should read
KS>
KS>             || (*from >= 0xA0)
KS>

Well, (0xA0 <= *from) and (*from >= 0xA0) are the same, aren't they?

as for the 0xFF thing, I suppose that the author wanted to "reflect" the
ranges as they are often written in mathematics:

  (' '  <= *from <= '~' ) or
  (*from == '\n') or
  (0xA0 <= *from <= 0xFF)

further, I don't know if ' ' and '~' have special meanings. If not it is
probably better to replace them with 0x20 and 0x7E, respectively.


c ya
        Sergei
-- 
--------------------------------------------------------------------  -?)
         eMail:       Sergei.Haller@math.uni-giessen.de               /\\
-------------------------------------------------------------------- _\_V
Be careful of reading health books, you might die of a misprint.
                -- Mark Twain



-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.