[vdr] Re: VDR developer version 1.3.0

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Sergei Haller wrote:
> 
> On Mon, 5 Jan 2004, Klaus Schmidinger (KS) wrote:
> 
> KS> Well, a further look into the original 'libdtv' code showed that
> KS> it had checked for
> KS>
> KS>          if ((*Buffer >= ' ' && *Buffer <= '~') || (*Buffer == '\n') ||
> KS>              (*Buffer >= 0xa0))
> KS>
> KS> while the new 'libsi' code checks
> KS>
> KS>        if (    ((' ' <= *from) && (*from <= '~'))
> KS>             || (*from == '\n')
> KS>             || ((0xA0 <= *from) && (*from <= 0xFF))
> KS>
> KS> I believe the last line here should read
> KS>
> KS>             || (*from >= 0xA0)
> KS>
> 
> Well, (0xA0 <= *from) and (*from >= 0xA0) are the same, aren't they?

Geee, so I _was_ blind! Sorry...

> as for the 0xFF thing, I suppose that the author wanted to "reflect" the
> ranges as they are often written in mathematics:
> 
>   (' '  <= *from <= '~' ) or
>   (*from == '\n') or
>   (0xA0 <= *from <= 0xFF)

Would be nice if C[++] allowed such a notation ;-)

> further, I don't know if ' ' and '~' have special meanings. If not it is
> probably better to replace them with 0x20 and 0x7E, respectively.

Hmm, the same would apply to '\n', but I guess that one does make things
clearer if written as '\n', so I'll just leave the other two there as well.

Klaus


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.