[vdr] Re: 1.3.0: Bug in filter.c

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Marcel Wiesweg wrote:
> 
> Hi,
> I found another bug and this time I'm the first to report this I guess ;-)
> 
> In filter.c I suggest
> 
> bool cFilter::Matches(u_short Pid, u_char Tid)
> {
> +  if (!on)
> +      return false;
>   for (cFilterData *fd = data.First(); fd; fd = data.Next(fd)) {
>       if (fd->Matches(Pid, Tid))
>          return true;
>       }
>   return false;
> }
> 
> Apart from being an optimisation, there is a bug when
> -a sticky filter data
> -requested by more than one filter
> -SetStatus(false)
> -as it is sticky it is left it in the list
> -sectionHandler->Del(fd) has no effect because fh->used remains >0
> => the data is still received

Thanks, I guess you're right here. Maybe this explains why sometimes
a new channel was found on the wrong 'source'...

Klaus


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.