[vdr] Re: ANNOUNCE: dvd-0.3.5b04

[André Weidemann <Andre.Weidemann@web.de>]

Hi,
I applied the vdr-1.3.10_spu_01.diff to vdr-1.3.10 and tried some DVD's. 
As it looks like, the subtitles still have some hick-ups.

I tried the German DVD "Keine halben Sachen" (The Whole 9 Yards). The 
Plugin claims that there is no subpicture at all. But with WinDVD it 
shows English and German as subtitles...

The other thing is, the forced subtitles don't seem to be working the 
way they should.
In the setup I chose German for the Menu, the Sound, and the Subpicture 
and I set Subtitles to "forced-only".
When I start up the "Lord of the Rings" DVD (HdR Die Gefährten) the 
Plugin starts up with de 1/5 and displays all the German subtitles and 
not only the forced onces.

The DVD "Lebe lieber ungewöhlich" (A life less ordinary) displays with 
wrong aspect ration even though 16:9 is displayed in the status bar, the 
video is diplayed as 4:3, resulting in "long" faces. The reason for this 
is, that the video_aspect for this stream is 4:3 but the dvd_aspect is 
16:9. The attached patch did the trick for the 0.3.4 Plugin.

 André.
diff -ruNbw dvd/player-dvd.c dvd_aspect_new/player-dvd.c
--- dvd/player-dvd.c	Sat Jun  5 14:46:22 2004
+++ dvd_aspect_new/player-dvd.c	Sat Jun  5 17:55:00 2004
@@ -1021,7 +1021,7 @@
     // if we are here, then
     //  TV==4:3 && DVD==16:9
     //
-    if (vaspect != 2) {
+    if ((vaspect != 2)||((vaspect==2 )&&(dvd_aspect==3)) ) {
         //
         //and the actual material on the DVD is not 4:3
         //
@@ -1036,6 +1036,9 @@
         // hsize  = o_hsize  / 16 * 3 * 4; // shorten hsize
         // vsize = o_vsize /  9 * 4 * 3; // stretched vsize
         // vsize = o_vsize /  ( 3 * 4 ) * 9 ; // shorten vsize
+ 	} else if ((vaspect==2 )&&(dvd_aspect==3)) { // use letterbox (honor dvd_aspect)
+	newMode = cSpuDecoder::eSpuLetterBox;
+	vaspect = 0x03;   // 16:9
         }
     }
     }