[vdr] Re: missing call in cSkins::Message() ?

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Andreas Regel wrote:
> 
> Klaus Schmidinger wrote:
> > Joachim Wilke wrote:
> >
> >>Hi everyone,
> >>
> >>I'm using VDR 1.3.15 and the lcdproc-plugin 0.0.10 and noticed,
> >>that displaying a message using the cSkins::Message() function
> >>triggers the same display on the lcd (thats ok) - but when the
> >>message is cleared from the tv screen, it does not dissappear on
> >>the lcd.
> >>
> > However, the actual fix should look like this:
> >
> > --- skins.c     2004/05/15 12:34:38     1.1
> > +++ skins.c     2004/11/06 11:25:46
> > @@ -186,10 +186,12 @@
> >          }
> >       else
> >          cSkinDisplay::Current()->SetMessage(Type, NULL);
> > +     cStatus::MsgOsdClear();
> >       }
> >    else if (!s && displayMessage) {
> >       delete displayMessage;
> >       displayMessage = NULL;
> > +     cStatus::MsgOsdClear();
> >       }
> >    return k;
> >  }
> 
> Shouldn't be used cStatus::MsgOsdStatusMessage(NULL) instead of
> cStatus::MsgOsdClear()?
> 
> Andreas

Well, it's a mix of the two, actually:

--- skins.c     2004/05/15 12:34:38     1.1
+++ skins.c     2004/11/07 09:46:46
@@ -183,13 +183,17 @@
      if (displayMessage) {
         delete displayMessage;
         displayMessage = NULL;
+        cStatus::MsgOsdClear();
         }
-     else
+     else {
         cSkinDisplay::Current()->SetMessage(Type, NULL);
+        cStatus::MsgOsdStatusMessage(NULL);
+        }
      }
   else if (!s && displayMessage) {
      delete displayMessage;
      displayMessage = NULL;
+     cStatus::MsgOsdClear();
      }
   return k;
 }


Klaus