[linux-dvb] Re: [REVISED -mm PATCH] v4l: add dvb support for dvico fusionhdtv3 gold-T

[Michael Krufky]

Johannes Stezenbach wrote:

>Michael Krufky wrote:
>  
>
>>I just relalized that my previous email was in slight error..... I need 
>>to add
>>select DVB_LGDT3302 into the cx88-dvb section of Kconfig.
>>
>>Anyhow, back to my previous point... cx88-dvb already had the #ifdef 
>>HAVE_FRONTEND ... I am just renaming this symbol to #ifdef 
>>CONFIG_DVB_FRONTEND
>>    
>>
>But if you add select DVB_LGDT3302 then the #ifdefs are pointless
>because they will always be true. If you remove the selects,
>then you should add something like this to the help CX88_DVB text:
>	help
>	  you need to select one of the following DVB frontend
>	  drivers: mt352, ..., LGDT3302
>	  Good luck with finding out which one is the right one.
>	  If in doubt select them all.
>
>See where the problem is?
>
Johannes-

Now I realize that I was unclear in my previous emails.  I know that 
adding "select DVB_LGDT3302" ends up having all of the frontends always 
being true.  This is fine with me.  I am not trying to prevent them from 
automatically being true.  What I am trying to do is remove the control 
from the top of the cx88-dvb.c, and move it INTO kconfig.  If you look 
at current kernel source:

linux-2.6.12/drivers/media/video/cx88/cx88-dvb.c, starting at line 33:

/* those two frontends need merging via linuxtv cvs ... */
#define HAVE_CX22702 1
#define HAVE_OR51132 1

...and moving down to line 41:

#if HAVE_CX22702
# include "cx22702.h"
#endif
#if HAVE_OR51132
# include "or51132.h"
#endif

The #if 's are already there, and they are set to true at the top of the 
file. They have been there since Gerd added them in cvs version 1.27 of 
cx88-dvb.c (Tue Feb 15 15:59:35 2005 UTC)   They are currently serving 
no function in this state.  However, if the symbols are renamed to 
CONFIG_DVB_CX22702, and the #define HAVE_CX22702 is removed from the 
top, then it means that it will STILL be true, because it is defined as 
true in kconfig by default.  This yeilds the same result => everything 
gets included.  However, the #if's are actually functional this way. In 
addition, it allows those that compile from video4linux cvs to be able 
to edit the makefile to prevent unwanted modules from being built, 
without looking through the actual code.  So in fact, this is MORE 
user-friendly.  I agree that it is good to have all frontends included 
by default, but the proper way to do this is by having them selected in 
Kconfig (or Makefile), not by forcing it from within cx88-dvb.c

-- 
Michael Krufky