[linux-dvb] problems and workaround when tuning to a channel with DD enabled

Wolfgang Rohdewald wolfgang at rohdewald.de
Wed Jun 8 15:38:54 CEST 2005


On Mittwoch 08 Juni 2005 15:26, Oliver Endriss wrote:
> I would remove the 'out' label completely. The way it is used is bad
> programming style. It's not required, a simple 'break' will do.

will do. I thought perhaps this might make gcc generate better code in
connection with so many inlined functions, so I didn't want to touch it.
 
> What are OSD_SetTrans, OSD_GetPixel, OSD_Query and OSD_Test good for?
> Obviously they are not implemented and should be removed,
> i.e. just return -EINVAL.

they are documented in <dvb/osd.h>. According to osd.h they should
return -1 for failure but I will follow your advice in my patch.

-- 
Wolfgang




More information about the linux-dvb mailing list