[linux-dvb] [PATCH] Correct 'unc' for CinergyT2

Johannes Stezenbach js at linuxtv.org
Sun Nov 20 02:48:50 CET 2005


On Wed, Nov 09, 2005 Stephen Williams wrote:
> The CinergyT2 driver currently supplies the total 'unc' (uncorrected
> block errors) rather than the difference since the last query. E.g:
...
> Note the constantly rising 'unc' value. The following patch to
> cinergyt2.c corrects this output:
 
> diff -u -r1.30 cinergyT2.c
> --- cinergyT2.c 31 Oct 2005 17:01:06 -0000      1.30
> +++ cinergyT2.c 9 Nov 2005 20:12:17 -0000
> @@ -592,10 +600,15 @@
>                                 (__u16 __user *) arg);
> 
>         case FE_READ_UNCORRECTED_BLOCKS:
> -               /* UNC are already converted to host byte order... */
> -               return put_user(stat->uncorrected_block_count,
> -                               (__u32 __user *) arg);
> +       {
> +               uint32_t unc_count;
> +
> +               unc_count = stat->uncorrected_block_count;
> +               stat->uncorrected_block_count = 0;
> 
> +               /* UNC are already converted to host byte order... */
> +               return put_user(unc_count,(__u32 __user *) arg);
> +       }
>         case FE_SET_FRONTEND:
>         {
>                 struct dvbt_set_parameters_msg *param = &cinergyt2->param;

Your patch is whitespace damaged (needed to apply with patch -l
and correct the indentation manually) but looks good to me.

Could you please provide your Signed-off-by: line?
(See linux/Documentation/SubmittingPatches)

Thanks,
Johannes



More information about the linux-dvb mailing list