[linux-dvb] Re: [PATCH] support for KWorld DVB-S 100 updated

Johannes Stezenbach js at linuxtv.org
Tue Nov 22 15:22:32 CET 2005


On Tue, Nov 22, 2005Vadim Catana wrote:
> Signed-off-by: Vadim Catana <skystar at moldova.cc>
> 
> updated patches with modifications suggested by Johannes Stezenbach.

Patch looks good to me except two very minor nits which we can
fix ourselves before commit:

> +	switch (state->config->use_isl6421) {
...
> +	case 1:
...
> +	case 0:

odd; why not if () ... else ... ?

> +static void enable_lnb_voltage(struct dvb_frontend* fe, int on)
> +{
> +	struct cx8802_dev *dev= fe->dvb->priv;
> +	struct cx88_core *core = dev->core;
> +
> +	if ( on == 1 ) {
> +		cx_write(MO_GP0_IO, 0x000006f9);
> +	} else {
> +		cx_write(MO_GP0_IO, 0x000006fB);
> +	}
> +}

unnecessary braces

Michael, since this touches both dvb and v4l files, can you commit both?


Thanks,
Johannes



More information about the linux-dvb mailing list