[linux-dvb] pluto2 patch

[Michal Semler]

Hi Johannes

Dne po 12. září 2005 12:33 Johannes Stezenbach napsal(a):
> On Sun, Sep 11, 2005 Michal Semler wrote:
> > I receive about 200 dmesg messages in 1 minut this fixes it, I think we
> > can easily remove this error message:
> >
> > --- /usr/src/linux/drivers/media/dvb/pluto2/pluto2.c    2005-09-11
> > 14:09:19.000000000 +0200
> > +++ /usr/src/linux/drivers/media/dvb/pluto2/pluto2.c    2005-09-11
> > 14:10:17.000000000 +0200
> > @@ -291,8 +291,8 @@
> >                         i += 188;
> >                 valid = i / 188;
> >                 if (nbpackets != valid) {
> > -                       dev_err(&pluto->pdev->dev, "nbpackets=%u
> > valid=%u\n", -                                       nbpackets, valid);
> > +       /*              dev_err(&pluto->pdev->dev, "nbpackets=%u
> > valid=%u\n", +                                       nbpackets, valid);
> > */
> >                         nbpackets = valid;
> >                 }
> >         }
> >
> > Thanks for applying!
>
> Maybe Andreas can comment on this, but commenting out error messages
> doesn't make the error go away.
> Can you post some of these messages so we can see the nbpackets and
> valid numbers?

yup, but before this code, there is a FIXME...so there is no clue and this 
problem causes laptop constantly writing to hdd (about 30 MB/evening)
At this time I prefer remove it or just make it available only in DEBUG mode.

I don't have card here now, but error I getts is something like
nbpackets=-1 valid=0

>
> > There is another bug when card is removed, driver says card hung many
> > times. This part of code is responsible for it:
> >
> >         if (tscr == 0xffffffff) {
> >                 // FIXME: maybe recover somehow
> >                 dev_err(&pluto->pdev->dev, "card hung up :(\n");
> >                 return IRQ_HANDLED;
> >
> > There should be probably
> > 		if (tscr == 0xffffffff) && !pcmcia_card_removed
> > to fix this.
> >
> > Do anybody know exact name of this funtion in pcmcia code?
>
> You mean you get this message once everytime you remove the card
> while it is still active?

Yes, when removing card from slot doesn't metter if I watch TV or not (card is 
only present in system). In that case I think there needs to be this check if 
card is removed from slot or not, because this error makes sense only when 
card is used and is in the pcmcia slot present.

>
>
> Johannes

Michal

-- 
S pozdravem

Michal Semler