[linux-dvb] build system problem with DVB_FE_CUSTOMISE
Andrew de Quincey
adq_dvb at lidskialf.net
Tue Aug 1 01:50:14 CEST 2006
On Tuesday 01 August 2006 00:44, Trent Piepho wrote:
> On Mon, 31 Jul 2006, Andrew de Quincey wrote:
> > On Monday 31 July 2006 16:47, Manu Abraham wrote:
> > > >>> Imho DVB_FE_CUSTOMISE was a bad idea and should be removed
> > > >>> completely.
> > > >>>
> > > >>> It does not hurt if more frontend drivers will be compiled than
> > > >>> actually needed. Keep it simple.
> > > >>
> > > >> I would tend to agree with you, but there was obviously a demand for
> > > >> this feature since the cx88/saa7134 drivers both had their own way
> > > >> of doing exactly this. This way at least means we don't need a
> > > >> zillion #ifdefs cluttering up the card driver code.
> > >
> > > If the zillion #ifdef's in there, if it is gone, that itself makes that
> > > code a bit better to read. It was really hard to read, the code in
> > > there without any layout at all with so much clutter.
> > yeah - the thing is tho, dvb_attach() by itself removes the ifdefs. It
> > means all frontends are compiled, but only some /loaded/.
> > FE_CUSTOMISE is a parallel system that lets you disable the /compilation/
> > of modules, and is just an extra we added "because we could". Should we
> > have tho?
> It lets you disabled loading front-end drivers when not using dvb_attach,
> for example on kernels that don't support it, or when not using modules at
> all, or if kernel auto module loading is disabled.
Ah yes, I'd forgotten that; a very good justification for its presence.
More information about the linux-dvb