[linux-dvb] Fwd: [PATCH] DVB-CORE: Bug in CRC-32 checking during ULE decapsulation on 64-bit system

Ang Way Chuang wcang at nrg.cs.usm.my
Fri Dec 15 02:38:41 CET 2006


On Friday 15 December 2006 00:44, Michael Krufky wrote:
> Ang Way Chuang wrote:
> > My name is Way Chuang :) I adopt chinese way of displaying name. Surname
> > first.
>
> Sorry about that, Way Chuang.  I also apologize in advance, because I will
> probably forget and make the same mistake again in the future.  :-P  I'll
> try to remember.
Haha. Perhaps,  you should call me WC (Water Closet) next time. Just kidding.
>
> > CRC-32 checking during ULE decapsulation always failed on x86_64 system
> > due to the size of a variable used to store CRC? Discovered this bug on
> > Fedora Core 6 with kernel-2.6.18-1.2849. The i686 counterpart has no such
> > problem. Attached is the output of dmesg showing the problem. Look for
> > the last few lines for indication. This patch has been tested on 64-bit
> > system as well as 32-bit system.
>
> Your patch produces the following:
>
>   CC [M]  /home/mk/v4l-dvb/v4l/dvb_net.o
> /home/mk/v4l-dvb/v4l/dvb_net.c: In function 'dvb_net_ule':
> /home/mk/v4l-dvb/v4l/dvb_net.c:628: warning: format '%#lx' expects type
> 'long unsigned int', but argument 3 has type 'u32'
> /home/mk/v4l-dvb/v4l/dvb_net.c:628: warning: format '%#lx' expects type
> 'long unsigned int', but argument 4 has type 'u32'
>
Oops, missed that one. Sorry.
> I fixed that problem with the following patch... (please see attached)
>
> Regards,
>
> Michael Krufky



More information about the linux-dvb mailing list