[linux-dvb] [PATCH]: Hauppauge Grey Remote support added

J.O. Aho trizt at iname.com
Wed Jan 18 03:08:17 CET 2006


On Tue, 17 Jan 2006, Michael Krufky wrote:

> Darren Salt wrote:
>
>> I demand that J.O. Aho may or may not have written...
>> 
>> 
>> > This is partly the same code I last year posted to the linux-kernel
>> > maillist with the modification of using parm to select the remote type.
>> > 
>> > 
>> I may not have seen that...
>> 
>> 
> To make a long story short, Ricardo made big changes today with respect to 
> the IR code.  He applied JO Aho's patch, and after the reorganization, he 
> realized that Darren's KEYTAB is a superset of JO Aho's...
>
> So, we killed JO Aho's Keytab... It is simply unnecessary.  Sure, there may 
> be 11 extra keys in Darren's Keytab, but no harm done.  Those codes simply 
> will never be used by that card...  Since the common keys are all the same, 
> there is no sense in declaring a separate keytab.
>
> Is this okay with you guys?  If not, please say so...

I do understand that we don't want to have the same code repeated in may 
places, as the PVR cards don't use the budget drivers, there is the 
problem that when loading ir-kbd-i2c (which is needed together with the 
ivtv drivers) the keytable won't be the right one.

So maybe it's better to lift out the keytable to a header, which both 
drivers can access and use.


-- 
      //Aho

  ------------------------------------------------------------------------
   E-Mail: trizt at iname.com            URL: http://www.kotiaho.net/~trizt/
      ICQ: 13696780
   System: Linux System                        (PPC7447/1000 AMD K7A/2000)
  ------------------------------------------------------------------------
             EU forbids you to send spam without my permission
  ------------------------------------------------------------------------



More information about the linux-dvb mailing list