[linux-dvb] [PATCH]: Hauppauge Grey Remote support added

Michael Krufky mkrufky at gmail.com
Wed Jan 18 03:21:21 CET 2006


On 1/17/06, J.O. Aho <trizt at iname.com> wrote:
> On Tue, 17 Jan 2006, Michael Krufky wrote:
> > Darren Salt wrote:
> >> > This is partly the same code I last year posted to the linux-kernel
> >> > maillist with the modification of using parm to select the remote type.
> >>
> > To make a long story short, Ricardo made big changes today with respect to
> > the IR code.  He applied JO Aho's patch, and after the reorganization, he
> > realized that Darren's KEYTAB is a superset of JO Aho's...
> >
> > So, we killed JO Aho's Keytab... It is simply unnecessary.  Sure, there may
> > be 11 extra keys in Darren's Keytab, but no harm done.  Those codes simply
> > will never be used by that card...  Since the common keys are all the same,
> > there is no sense in declaring a separate keytab.
> >
> > Is this okay with you guys?  If not, please say so...
>
> I do understand that we don't want to have the same code repeated in may
> places, as the PVR cards don't use the budget drivers, there is the
> problem that when loading ir-kbd-i2c (which is needed together with the
> ivtv drivers) the keytable won't be the right one.
>
> So maybe it's better to lift out the keytable to a header, which both
> drivers can access and use.

That's basically what Ricardo did today.  He moved all of the v4l
keytables from the individual drivers all into ir-keytab.c , and they
are declared for external use inside ir-common.h .... right now, it
doesnt look like DVB is using ir-common, but it CAN be made to. 
(would be nice) ...  Now that all the v4l keytables are in a single
file, we can easily prevent duplicates from being created.

-Mike



More information about the linux-dvb mailing list