[linux-dvb] [PATCH 4/4] budget-ci: kzalloc conversion, be slightly more verbose about IR init

Darren Salt linux at youmustbejoking.demon.co.uk
Wed Mar 29 19:17:17 CEST 2006


I demand that Johannes Stezenbach may or may not have written...

> On Wed, Mar 22, 2006, Darren Salt wrote:
>> Convert to kzalloc.
> ...
>> @@ -1032,7 +1036,7 @@
>>  	struct budget_ci *budget_ci;
>>  	int err;

>> -	if (!(budget_ci = kmalloc(sizeof(struct budget_ci), GFP_KERNEL)))
>> +	if (!(budget_ci = kzalloc(sizeof(struct budget_ci), GFP_KERNEL)))
>>  		return -ENOMEM;

>>  	dprintk(2, "budget_ci: %p\n", budget_ci);

> This looks a bit suspicous. Was the zeroing of *budget_ci missing before or
> is it unnecessary?

It was missing. (It seems likely that the memset() would have been present
immediately before that dprintk().)

It occurs to me that the nearby assignment of budget->budget.ci_present is
now unnecessary...

-- 
| Darren Salt    | linux or ds at              | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| + Buy less and make it last longer.         INDUSTRY CAUSES GLOBAL WARMING.

If we don't succeed, we run the risk of failure.



More information about the linux-dvb mailing list