[linux-dvb] [PATCH] selectable frontend for Lifeview Trio

[Hartmut Hackmann]

Hi, Nico

Nico Sabbi wrote:
> Hi,
> since the good Andrew forgot once again to commit this patch :) here it 
> is again:
> it permits to select the frontend to use in the Lifeview Trio:
> trio_frontend=1 => satellitar
> trio_frontend=0 => terrestrial
> 
> Signed-off by Nico Sabbi (nsabbi at tiscali.it)
> 
> 
> ------------------------------------------------------------------------
> 
> --- saa7134-dvb.c.orig	2006-07-30 12:08:06.000000000 +0200
> +++ saa7134-dvb.c	2006-07-30 22:17:14.000000000 +0200
> @@ -51,6 +51,10 @@
>  module_param(antenna_pwr, int, 0444);
>  MODULE_PARM_DESC(antenna_pwr,"enable antenna power (Pinnacle 300i)");
>  
> +static int trio_frontend = 0;
> +module_param(trio_frontend, int, 0644);
> +MODULE_PARM_DESC(trio_frontend,"frontend to enable in the Lifeview Trio card (0: terrestrial, 1: satellitar)");
> +
>  /* ------------------------------------------------------------------ */
>  static int pinnacle_antenna_pwr(struct saa7134_dev *dev, int on)
>  {
> @@ -1154,12 +1158,24 @@
>  		}
>  		break;
>  	case SAA7134_BOARD_FLYDVB_TRIO:
> +		if(! trio_frontend) {	//terrestrial
>  		dev->dvb.frontend = dvb_attach(tda10046_attach, &lifeview_trio_config,
>  						    &dev->i2c_adap);
>  		if (dev->dvb.frontend) {
>  			dev->dvb.frontend->ops.tuner_ops.sleep = lifeview_trio_tuner_sleep;
>  			dev->dvb.frontend->ops.tuner_ops.set_params = lifeview_trio_tuner_set_params;
>  		}
> +		} else {		//satellitar
> +		dev->dvb.frontend = dvb_attach(tda10086_attach, &flydvbs, &dev->i2c_adap);
> +		if (dev->dvb.frontend) {
> +			if (dvb_attach(tda826x_attach, dev->dvb.frontend, 0x63, &dev->i2c_adap, 0) == NULL) {
> +				printk("%s: Lifeview Trio, No tda826x found!\n", __FUNCTION__);
> +			}
> +			if (dvb_attach(isl6421_attach, dev->dvb.frontend, &dev->i2c_adap, 0x08, 0, 0) == NULL) {
> +				printk("%s: Lifeview Trio, No ISL6421 found!\n", __FUNCTION__);
> +			}
> +		}
> +		}
>  		break;
>  	case SAA7134_BOARD_ADS_DUO_CARDBUS_PTV331:
>  		dev->dvb.frontend = dvb_attach(tda10046_attach, &ads_tech_duo_config,
> 
> 
> ------------------------------------------------------------------------
> 
I think this is a good intermediate solution. I can integrate it.
Would you accept a more generic name for the option like
"use_frontend"? I could do the same for the MD8800.
Please leave me a note. May i still add your signature if i change this?

Hartmut