[linux-dvb] Re: 3 patches for Kernel 2.6.19-rc5

[Mauro Carvalho Chehab]

Em Ter, 2006-11-14 às 17:47 +0100, Uwe Bugla escreveu:
> Hi everybody,

> Number ONE:
> --- a/Documentation/dvb/bt8xx.txt
> +++ b/Documentation/dvb/bt8xx.txt
> @@ -9,9 +9,15 @@
>  Please see Documentation/dvb/cards.txt => o Cards based on the Conexant Bt8xx PCI bridge:
>  
>  Compiling kernel please enable:
> -a.)"Device drivers" => "Multimedia devices" => "Video For Linux" => "BT848 Video For Linux"
> +a.)"Device drivers" => "Multimedia devices" => "Video For Linux" => "Enable Video for Linux API 1 (DEPRECATED)"
> -b.)"Device drivers" => "Multimedia devices" => "Digital Video Broadcasting Devices"
> - => "DVB for Linux" "DVB Core Support" "Bt8xx based PCI Cards"
> +b.)"Device drivers" => "Multimedia devices" => "Video For Linux" => "Video Capture Adapters" => "BT848 Video For Linux"
> +c.)"Device drivers" => "Multimedia devices" => "Digital Video Broadcasting Devices"
> + => "DVB for Linux" "DVB Core Support" "Bt8xx based PCI Cards"
> +
> +Note: If you know the frontend driver that your specific card needs furthermore please enable:
No. For most users, it is a risky option to allow DVB_CUSTOMISE. A
warning should be added here, marking that this option may make DVB to
stop working.
> +d.)"Device drivers" => "Multimedia devices" => "Digital Video Broadcasting Devices"
> + => "DVB for Linux" "DVB Core Support" "Customize DVB Frontends" => "Customize the frontend modules to build"
> + Then you can save memory by deselecting every frontend module your specific card does not need.
Same as above.
>  
>  2) Loading Modules
>  ==================
> 
> Number TWO:
> --- a/drivers/media/dvb/bt8xx/Kconfig
> +++ b/drivers/media/dvb/bt8xx/Kconfig
> @@ -1,7 +1,7 @@
>  config DVB_BT8XX
>      tristate "BT8xx based PCI cards"
>      depends on DVB_CORE && PCI && I2C && VIDEO_BT848
> -    select DVB_PLL
> +    select DVB_PLL if !DVB_FE_CUSTOMISE
>      select DVB_MT352 if !DVB_FE_CUSTOMISE
>      select DVB_SP887X if !DVB_FE_CUSTOMISE
>      select DVB_NXT6000 if !DVB_FE_CUSTOMISE
> --- a/drivers/media/dvb/frontends/Kconfig
> +++ b/drivers/media/dvb/frontends/Kconfig
> @@ -264,8 +264,11 @@
>      depends on DVB_CORE
>  
>  config DVB_PLL
> -    tristate
> +    tristate "PLL support for DVB tuners"
>      depends on DVB_CORE && I2C
> +    default m if !DVB_FE_CUSTOMISE
> +    help
> +      You can safely deselect this if you're only running a Pinnacle PCTV Sat DVB-S card.
This comment doesn't help. For 99,9% of the current DVB boards, DVB_PLL
is needed. So, help should be something like "this is required for most
boards. You should disable it only if you know what you are doing".
>  
>  config DVB_TDA826X
>      tristate "Philips TDA826X silicon tuner"
> 
> Number Three: (the destructive RAM saver!)
>  
> -static struct dst_config dst_config = {
> -    .demod_address = 0x55,
> -};
<snip/>
NO! You are just removing DST support from the driver! Saves some memory
for your board, but breaks support for a large number of boards.


Cheers, 
Mauro.