[linux-dvb] [patch 0/8] budget_ci: improve IR input handling

Andrew de Quincey adq_dvb at lidskialf.net
Wed Nov 22 22:07:49 CET 2006


On Monday 20 November 2006 21:23, David Härdeman wrote:
> On Sun, Nov 19, 2006 at 08:11:15PM +0000, Andrew de Quincey wrote:
> >On Sunday 19 November 2006 19:12, Darren Salt wrote:
> >> I demand that Andrew de Quincey may or may not have written...
> >>
> >> > On Tuesday 03 October 2006 01:01, David Härdeman wrote:
> >> >> This series of patches includes a number of bugfixes and changes to
> >> >> the IR input handling of the budget-ci driver.
> >>
> >> [snip]
> >>
> >> > Patches look good - however I think the mailer has screwed them up
> >> > (there seem to be stray tabs at the end of many lines).
> >>
> >> I see no such problem with them. Since they were sent using quilt (at
> >> least according to the headers, and I'd expect quilt _not_ to make a
> >> mess of them), perhaps KMail is the culprit?
> >
> >Not sure whats up TBH, and I dont have the time to spare to investigate
> > just now. If you have them lying about there anyway, it would make it
> > much easier for me if you could just resend them.
>
> I've refreshed the patches against a current version of the v4l-dvb tree
> and made sure that they apply cleanly. To make sure that no mailers
> mangle the patches, I've posted them at:
> http://david.hardeman.nu/files/patches/dvb/budget-ci_ir_v2/
>
> If you'd prefer I remail them to the list, just tell me.

Hi thanks - afraid theres a compile error:

/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c: In 
function 'msp430_ir_debounce':
/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c:195: error: 'key_map' 
undeclared (first use in this function)
/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c:195: error: (Each 
undeclared identifier is reported only once
/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c:195: error: for each 
function it appears in.)
/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c: At top level:
/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c:206: error: redefinition 
of 'msp430_ir_interrupt'
/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c:125: error: previous 
definition of 'msp430_ir_interrupt' was here
/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c: In 
function 'msp430_ir_interrupt':
/home/adq/dev/dvb/linuxtv.org/v4l-dvb/v4l/budget-ci.c:221: error: 'key_map' 
undeclared (first use in this function)


Seems there are two versions of msp430_ir_interrupt in the file... I assume I 
just need to delete the second one, but can you confirm please?



More information about the linux-dvb mailing list