[linux-dvb] [PATCH] fix NULL pointer dereference in NOVA T USB2 Remote Control

Patrick Boettcher patrick.boettcher at desy.de
Thu Oct 12 12:08:27 CEST 2006


On Tue, 10 Oct 2006, Mario Rossi wrote:

> I've tried your repository a few minutes ago.
> The card works (AGC) and te remote control as well (no NULL pointer
> exception).
> 
> What about this patch to remove unnecessary (and misleading) debug
> output (it prints the values of the keys in the table up to the value
> of the key pressed)?
> 
> diff -r 0e4be24ee6c0 linux/drivers/media/dvb/dvb-usb/nova-t-usb2.c
> --- a/linux/drivers/media/dvb/dvb-usb/nova-t-usb2.c     Sun Oct 08
> 20:44:05 2006 +0200
> +++ b/linux/drivers/media/dvb/dvb-usb/nova-t-usb2.c     Tue Oct 10
> 00:07:08 2006 +0100
> @@ -90,9 +90,9 @@ static int nova_t_rc_query(struct dvb_us
>                        deb_rc("raw key code 0x%02x, 0x%02x, 0x%02x to
> c: %02x d: %02x toggle:
> %d\n",key[1],key[2],key[3],custom,data,toggle);
> 
>                        for (i = 0; i < ARRAY_SIZE(haupp_rc_keys); i++) {
> -                               deb_rc("c: %x, d:
> %x\n",haupp_rc_keys[i].data,haupp_rc_keys[i].custom);
>                                if (haupp_rc_keys[i].data == data &&
>                                        haupp_rc_keys[i].custom == custom) {
> +                                        deb_rc("c: %x, d:
> %x\n",haupp_rc_keys[i].data,haupp_rc_keys[i].custom);
>                                        *event = haupp_rc_keys[i].event;
>                                        *state = REMOTE_KEY_PRESSED;
>                                        if (st->old_toggle == toggle) {
> 

I will apply it later - as it is not so important for 2.6.19.

thanks,
Patrick.



More information about the linux-dvb mailing list