[linux-dvb] [patch 1/6] honor DESTDIR and libdir in order to ease rpm builds

[Ludwig Nussel]

[I'm sorry, I somehow missed that mail]

 On Thursday 07 September 2006 20:06, Christoph Pfister wrote:
> Am Donnerstag, 7. September 2006 15:08 schrieb Ludwig Nussel:
> > [...]
> >  ifneq ($(libraries),)
> >  	@echo installing libraries
> > -	@mkdir -p $(prefix)/lib
> > -	@install -m 644 $(libraries) $(prefix)/lib/
> > +	@mkdir -p $(DESTDIR)$(libdir)
> > +	@install -m 644 $(libraries) $(DESTDIR)$(libdir)
> >  endif
> >  ifneq ($(inst_bin),)
> >  	@echo installing binaries
> > -	@mkdir -p $(prefix)/bin
> > -	@install -m 755 $(inst_bin) $(prefix)/bin/
> > +	@mkdir -p $(DESTDIR)$(prefix)/bin
> > +	@install -m 755 $(inst_bin) $(DESTDIR)$(prefix)/bin/
> >  endif
> >  endif
> 
> I will add something like "prefix ?= $(DESTDIR)", ok?

$prefix and $DESTDIR should not be mixed. $prefix gets compiled into
binaries and you don't want to accidently have $DESTDIR in there as
well. Also I find it very annoying if packages use $DESTDIR
differently than automake.

The additional define of $libdir is useful for biarch platforms like
x86_64 as libraries have to be installed into /lib64 instead of /lib
there.

cu
Ludwig

-- 
 (o_   Ludwig Nussel
 //\   SUSE LINUX Products GmbH, Development
 V_/_  http://www.suse.de/