[linux-dvb] Re: [v4l-dvb-maintainer] Patch kworld dvb-t 210 diff file

Trent Piepho xyzzy at speakeasy.org
Mon Apr 2 02:11:42 CEST 2007


On Sat, 31 Mar 2007, john owen-jones wrote:
> I apologise for doing this incorrectly but i haven't a clue how to upload
> the diff file

After you make your changes, run 'make commit'.  This will give you a
pre-made log message to fill in and also fix certain things (e.g. add new
cards to the correct CARDLIST file).

After that, you can use 'hg export tip' to produce a patch to send to the
list.  The premade log message you filled in will have the correct
signed-off-by line.

> +	.radio_addr    = ADDR_UNSET,
> +	.mpeg           = SAA7134_MPEG_DVB,
> +	.gpiomask       = 1 << 21,
> +	.inputs = {{
> +	    .name   = name_tv,
> +	    .vmux   = 1,
> +	    .amux   = TV,
> +	    .tv     = 1,
> +	},{

Please follow the existing indentation style.

> -
> +// my addition
> +#define SAA7134_BOARD_KWORLD_DVBT_210 113
> +// added the dvbt 210 as card 113

Don't add comments like those.  There have been some 51,000 patches applied
to the kernel since 2.6.12.  Imagine what it would look like if there were
51,000 "// my addition" lines in there.



More information about the linux-dvb mailing list