[linux-dvb] Re: [v4l-dvb-maintainer] Patch kworld dvb-t 210 diff file

Michael Krufky mkrufky at linuxtv.org
Mon Apr 2 02:29:50 CEST 2007


john owen-jones wrote:
> hi
> I apologise for doing this incorrectly but i haven't a clue how to
> upload the diff file
> this works very well with the kworld dvb-t 210 essentially its a clone
> of a philips reference design and really just entails identifying the card.
> 
> I checked out the source using
> clone http://linuxtv.org/hg/v4l-dvb
> I have modified the source and created a diff file for the kworld DVB-T 210
> 
> Everything seems to work fine however i don't know how to upload the
> diff file so i am posting it here.
> essentially its the same as
> http://lists-archives.org/video4linux/15273-kworld-dvb-t-210-support.html
> but this patch is out of date (my previous patch 6 weeks ago is also out
> of date (not uploaded))
> with these modifications the card is working fine with ubuntu feisty beta
> it worked well with ubuntu edgy too
> 
> please can someone get this included in the source tree
> feel free to contact me at blackest_knight at hotmail.com
> here is the diff file
> 
> diff -r 9fa3de301eac linux/drivers/media/video/saa7134/saa7134-cards.c
> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c    Fri Mar 30
> 17:34:14 2007 -0300
> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c    Sat Mar 31
> 14:08:36 2007 +0100
> @@ -3447,6 +3447,35 @@ struct saa7134_board saa7134_boards[] =
>             .gpio = 0x0200000,
>         },
>     },
> +    [SAA7134_BOARD_KWORLD_DVBT_210] = {
> +    .name           = "KWorld DVB-T 210",
> +    .audio_clock    = 0x00187de7,
> +    .tuner_type     = TUNER_PHILIPS_TDA8290,
> +    .radio_type     = UNSET,
> +    .tuner_addr    = ADDR_UNSET,
> +    .radio_addr    = ADDR_UNSET,
> +    .mpeg           = SAA7134_MPEG_DVB,
> +    .gpiomask       = 1 << 21,
> +    .inputs = {{
> +        .name   = name_tv,
> +        .vmux   = 1,
> +        .amux   = TV,
> +        .tv     = 1,
> +    },{
> +        .name   = name_comp1,
> +        .vmux   = 3,
> +        .amux   = LINE1,
> +    },{
> +        .name   = name_svideo,
> +        .vmux   = 8,
> +        .amux   = LINE1,
> +    }},
> +    .radio = {
> +        .name   = name_radio,
> +        .amux   = TV,
> +        .gpio   = 0x0200000,
> +    },
> +    },
> };
> 
> const unsigned int saa7134_bcount = ARRAY_SIZE(saa7134_boards);
> @@ -3953,6 +3982,12 @@ struct pci_device_id saa7134_pci_tbl[] =
>         .subvendor    = 0x17de,
>         .subdevice    = 0x7201,
>         .driver_data  = SAA7134_BOARD_TEVION_DVBT_220RF,
> +    },{
> +        .vendor       = PCI_VENDOR_ID_PHILIPS,
> +        .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
> +        .subvendor    = 0x17de,
> +        .subdevice    = 0x7250,
> +        .driver_data  = SAA7134_BOARD_PHILIPS_TIGER,



Why is the new card's autodetection set to SAA7134_BOARD_PHILIPS_TIGER,
yet, you added a new card definition, SAA7134_BOARD_KWORLD_DVBT_210 ?



>     },{
>         .vendor       = PCI_VENDOR_ID_PHILIPS,
>         .device       = PCI_DEVICE_ID_PHILIPS_SAA7133, /* SAA7135HL */
> @@ -4503,6 +4538,7 @@ int saa7134_board_init2(struct saa7134_d
>         }
>         break;
>     case SAA7134_BOARD_PINNACLE_PCTV_310i:
> +    case SAA7134_BOARD_KWORLD_DVBT_210:
>     case SAA7134_BOARD_TEVION_DVBT_220RF:
>     case SAA7134_BOARD_ASUSTeK_P7131_DUAL:
>     case SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA:
> diff -r 9fa3de301eac linux/drivers/media/video/saa7134/saa7134-dvb.c
> --- a/linux/drivers/media/video/saa7134/saa7134-dvb.c    Fri Mar 30
> 17:34:14 2007 -0300
> +++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c    Sat Mar 31
> 13:54:10 2007 +0100
> @@ -1040,6 +1040,7 @@ static int dvb_init(struct saa7134_dev *
>             dev->dvb.frontend->ops.tuner_ops.set_params =
> philips_tda6651_pll_set;
>         }
>         break;
> +    case SAA7134_BOARD_KWORLD_DVBT_210:
>     case SAA7134_BOARD_PHILIPS_TIGER:
>         configure_tda827x_fe(dev, &philips_tiger_config);
>         break;
> diff -r 9fa3de301eac linux/drivers/media/video/saa7134/saa7134.h
> --- a/linux/drivers/media/video/saa7134/saa7134.h    Fri Mar 30 17:34:14
> 2007 -0300
> +++ b/linux/drivers/media/video/saa7134/saa7134.h    Sat Mar 31 13:05:52
> 2007 +0100
> @@ -242,7 +242,9 @@ struct saa7134_format {
> #define SAA7134_BOARD_AVERMEDIA_M102       110
> #define SAA7134_BOARD_ASUS_P7131_4871       111
> #define SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA 112
> -
> +// my addition
> +#define SAA7134_BOARD_KWORLD_DVBT_210 113
> +// added the dvbt 210 as card 113
> #define SAA7134_MAXBOARDS 8
> #define SAA7134_INPUT_MAX 8
> 

-Mike



More information about the linux-dvb mailing list