[linux-dvb] [BUG] flexcop lockdep

Antti Seppälä ajhseppa at niksula.hut.fi
Sat Apr 7 09:30:07 CEST 2007


Patrick Boettcher wrote:
> On Fri, 6 Apr 2007, Antti Seppälä wrote:
> 
>> Patrick Boettcher wrote:
>>
>>> Someone outthere with a SMP-system and a flexcop who could see if e.g.
>>> dvbscan or dvbtraffic is killing the system/flexcop when removing the
>>> irq_lock?
>>>
>>> Patrick.
>>
>> I've now been torturing my SMP box for over three hours with various dvb
>> -related activities (dvbtraffic, dvbscan, vdr) without the irq_lock in flexcop
>> driver. So far I haven't noticed any problems in operation whatsoever.
>>
>> Maybe the spinlock really should go?
> 
> I vote for it, too.
> 
> If someone will have a problem with the flexcop we will see during 
> development phase of the kernel after integration.
> 
> regards,
> Patrick.


I've created a patch for removing the spinlock from latest v4l-dvb -tree:


Removing of unnecessary spinlock

Based on the discussion on linux-dvb it seems that ISR:s are already
serialized by the linux kernel and thus drivers won't have to specify
their own facilities for ISR serialization.

Signed-off-by: Antti Seppälä <ajhseppa at niksula.hut.fi>


-- 
Antti Seppälä
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flexcop-spinlock-removal.patch
Type: text/x-patch
Size: 1043 bytes
Desc: not available
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20070407/a9e8d158/flexcop-spinlock-removal-0001.bin


More information about the linux-dvb mailing list