[linux-dvb] Re: [video4linux-cvs] [hg:v4l-dvb] Add support for Opera S1- DVB-USB

Mauro Carvalho Chehab mchehab at infradead.org
Thu Apr 19 22:22:17 CEST 2007


> @@ -93,17 +100,31 @@ static int opera1_usb_i2c_msgxfer(struct
<snip/>
> 	
> +	switch (addr>>1){
<snip/>


>  		if ((tmp = opera1_usb_i2c_msgxfer(d,
> -					msg[i].addr,
> +					(msg[i].addr<<1)|(msg[i].flags&I2C_M_RD?0x01:0),

Hmm... wouldn't better to remove the >>1 and <<1 on both sides, using
only 7bit addresses?

> +       return opera1_xilinx_rw(d->udev, 0xb7, val,
> +                               &val, 1, OPERA_WRITE_MSG);

By using only 7-bit address, you will need also to do 0xb7>>1 above.


-- 
Cheers,
Mauro




More information about the linux-dvb mailing list