[linux-dvb] Re: [video4linux-cvs] [hg:v4l-dvb] Add support for Opera S1- DVB-USB

Michael Krufky mkrufky at linuxtv.org
Mon Apr 23 23:26:21 CEST 2007


Michael Krufky wrote:
> Marco Gittler wrote:
>> here the new patch against main hg.
>> -the tuner i2c addr now without define (as wanted).
>> -now 7 bit addr are used (the power_ctrl fkt ist ok so, because this
>> is a raw write)
>> -the addr >> 1 , addr << 1 is ok so, i think beause the read write is
>> now taken from the last bit.
>> -now i have no datasheet for the device, all taken from usb-logs
>>
>> i hope i answered all asked questions.
>>
>> Signed-off-by: Marco Gittler <g.marco at freenet.de>
> Looks good... Still some trivial issues that can be fixed after the
> fact.  See below for more comments. Meanwhile,
> 
> Mauro,
> 
> Please pull from:
> 
> http://linuxtv.org/hg/~mkrufky/opera
> 
> for Marco's patch:
> 
> - opera: use 7-bit i2c addresses
> 
>  dvb-usb-ids.h |    2
>  opera1.c      |   80 +++++++++++++++++++++++---------------
>  2 files changed, 50 insertions(+), 32 deletions(-)
> 
> 
> Marco,
> 
> The only outstanding issues left that I see are whitespace-related
> problems.  The repository whitespace stripper made a few cleanups,
> besides that, you should still fix up some of these statements by
> inserting spaces between operators.  For example:

Ah, I forgot to mention the variable-length array.  I believe that it was Felix
who had suggested a possible better solution.  Do you intend to fix that also,
Marco?

Regards,
Michael Krufky




More information about the linux-dvb mailing list