[linux-dvb] [RFC PATCH] Choose dvb adapter number with a driver specific module option

Manu Abraham abraham.manu at gmail.com
Sat Aug 4 05:12:15 CEST 2007


On 8/4/07, Janne Grunau <janne-dvb at grunau.be> wrote:
> On Saturday 04 August 2007 00:02:29 Manu Abraham wrote:
> >
> > Do we really want to have adapter numbers in DVB bridge drivers ?
> > IMHO, it doesn't look pleasing to have that.
>
> I think it's worthwhile to have it.
> >
> > Is there any other possible better alternatives ?
>
> Something similiar is possible with udev rules but I wouldn't say that
> it is a better alternative.


Why ? If you can achieve the same without any code change, doesn't
that look better ?


> > If it is that
> > absolute a necessity, can we hide the ugliness in dvb-core at least ?
>
> I'm not really sure what you mean exactly. If you want to avoid changes
> in the bridge drivers I don't see a way to archieve that. If you want
> the changes as small as possible look at the final patch.


That one looks better than your first patch. (Although i hate having a
MAX limit defined)

I meant adding a module parameter to each module, which was a bit, ..
I don't know how come others said that they liked the first one very
much.


> One line for
> the module parameter and the added parameter for the register function.
> I don't think it can be done with less changes.


True.



More information about the linux-dvb mailing list