[linux-dvb] [PATCH] Fix for Air2PC HD5000

[Michael Krufky]

Trent Piepho wrote:

>On Wed, 8 Aug 2007, Michael Krufky wrote:
>  
>
>>>On Wed, 8 Aug 2007, Geoffrey Hausheer wrote:
>>>
>>>
>>>      
>>>
>>>>On 8/8/07, Michael Krufky mkrufky-at-linuxtv.org wrote:
>>>>
>>>>
>>>>        
>>>>
>>>>>On 8/7/07, Geoffrey Hausheer wrote:
>>>>>Although your patch may appear to fix your problem, I suspect that it
>>>>>is really curing a symptom of the problem, and not the cause.
>>>>>
>>>>>
>>>>>          
>>>>>
>>>>This is possible.  I don't know anything at all about i2c.  I just
>>>>tried to reverted the negative consequences of the patch which broke
>>>>my system.
>>>>
>>>>
>>>>        
>>>>
>>>The real problem is with the flexcop i2c support.  It only allows a very
>>>limited set of a i2c commands, and a one byte read command like the pll
>>>probe uses isn't supported.
>>>
>>>      
>>>
>>Trent,
>>
>>If that is the case, then why do you think Geoffrey is having this
>>problem while others are not?
>>    
>>
>
>The HD-5000 is the only flexcop card that uses dvb-pll with a pll directly
>attached to the I2C bus.
>
>The flexcop driver doesn't check the return value of dvb_pll_attach, so
>there is no error message.  It will just not work correctly.
>

Perhaps I worded my question incorrectly...  When I said, "others are 
not", I meant other users of the HD5000.  If you look back to earlier in 
this thread, I gave an explanation of the testing that I have done last 
weekend.  Using 2.6.22, the initial tuning params work properly and all 
attempts afterwards do not.

Regardless, things are now beginning to make sense, although I do not 
understand why the latest HG works fine with that card for me against 
eariler kernel revisions.  Perhaps I made a mistake in one of my tests.  
Now I know exactly what needs testing.  How to fix this cleanly, that I 
am still not sure of, without affecting other drivers.  Maybe we'll have 
to hack the flexcop i2c handling to fake a good i2c reply.  I'll look 
into it when I get back home.

-Mike